| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1192530223.7205.25.camel@pasglop>
Date: Tue, 16 Oct 2007 20:23:43 +1000
From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
To: Roland McGrath <roland@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
linuxppc-dev@...abs.org, Paul Mackerras <paulus@...ba.org>,
Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
Anton Blanchard <anton@...ba.org>
Subject: Re: [PATCH] powerpc64 vDSO: linker script indentation
On Mon, 2007-10-15 at 20:43 -0700, Roland McGrath wrote:
> This cleans up the formatting in the vDSO linker script, mostly just the
> use of whitespace. It's intended to approximate the kernel standard
> conventions for indenting C, treating elements of the linker script about
> like initialized variable definitions.
>
> Signed-off-by: Roland McGrath <roland@...hat.com>
> CC: Sam Ravnborg <sam@...nborg.org>
Thanks Roland !
Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> ---
> arch/powerpc/kernel/vdso64/vdso64.lds.S | 225 +++++++++++++++++--------------
> 1 files changed, 122 insertions(+), 103 deletions(-)
>
> diff --git a/arch/powerpc/kernel/vdso64/vdso64.lds.S b/arch/powerpc/kernel/vdso64/vdso64.lds.S
> index 2d70f35..932b3fd 100644
> --- a/arch/powerpc/kernel/vdso64/vdso64.lds.S
> +++ b/arch/powerpc/kernel/vdso64/vdso64.lds.S
> @@ -10,100 +10,114 @@ ENTRY(_start)
>
> SECTIONS
> {
> - . = VDSO64_LBASE + SIZEOF_HEADERS;
> - .hash : { *(.hash) } :text
> - .gnu.hash : { *(.gnu.hash) }
> - .dynsym : { *(.dynsym) }
> - .dynstr : { *(.dynstr) }
> - .gnu.version : { *(.gnu.version) }
> - .gnu.version_d : { *(.gnu.version_d) }
> - .gnu.version_r : { *(.gnu.version_r) }
> -
> - .note : { *(.note.*) } :text :note
> -
> - . = ALIGN (16);
> - .text :
> - {
> - *(.text .stub .text.* .gnu.linkonce.t.*)
> - *(.sfpr .glink)
> - } :text
> - PROVIDE (__etext = .);
> - PROVIDE (_etext = .);
> - PROVIDE (etext = .);
> -
> - . = ALIGN(8);
> - __ftr_fixup : {
> - *(__ftr_fixup)
> - }
> -
> - . = ALIGN(8);
> - __fw_ftr_fixup : {
> - *(__fw_ftr_fixup)
> - }
> -
> - /* Other stuff is appended to the text segment: */
> - .rodata : { *(.rodata .rodata.* .gnu.linkonce.r.*) }
> - .rodata1 : { *(.rodata1) }
> - .eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr
> - .eh_frame : { KEEP (*(.eh_frame)) } :text
> - .gcc_except_table : { *(.gcc_except_table) }
> -
> - .opd ALIGN(8) : { KEEP (*(.opd)) }
> - .got ALIGN(8) : { *(.got .toc) }
> - .rela.dyn ALIGN(8) : { *(.rela.dyn) }
> -
> - .dynamic : { *(.dynamic) } :text :dynamic
> -
> - _end = .;
> - PROVIDE (end = .);
> -
> - /* Stabs debugging sections are here too
> - */
> - .stab 0 : { *(.stab) }
> - .stabstr 0 : { *(.stabstr) }
> - .stab.excl 0 : { *(.stab.excl) }
> - .stab.exclstr 0 : { *(.stab.exclstr) }
> - .stab.index 0 : { *(.stab.index) }
> - .stab.indexstr 0 : { *(.stab.indexstr) }
> - .comment 0 : { *(.comment) }
> - /* DWARF debug sectio/ns.
> - Symbols in the DWARF debugging sections are relative to the beginning
> - of the section so we begin them at 0. */
> - /* DWARF 1 */
> - .debug 0 : { *(.debug) }
> - .line 0 : { *(.line) }
> - /* GNU DWARF 1 extensions */
> - .debug_srcinfo 0 : { *(.debug_srcinfo) }
> - .debug_sfnames 0 : { *(.debug_sfnames) }
> - /* DWARF 1.1 and DWARF 2 */
> - .debug_aranges 0 : { *(.debug_aranges) }
> - .debug_pubnames 0 : { *(.debug_pubnames) }
> - /* DWARF 2 */
> - .debug_info 0 : { *(.debug_info .gnu.linkonce.wi.*) }
> - .debug_abbrev 0 : { *(.debug_abbrev) }
> - .debug_line 0 : { *(.debug_line) }
> - .debug_frame 0 : { *(.debug_frame) }
> - .debug_str 0 : { *(.debug_str) }
> - .debug_loc 0 : { *(.debug_loc) }
> - .debug_macinfo 0 : { *(.debug_macinfo) }
> - /* SGI/MIPS DWARF 2 extensions */
> - .debug_weaknames 0 : { *(.debug_weaknames) }
> - .debug_funcnames 0 : { *(.debug_funcnames) }
> - .debug_typenames 0 : { *(.debug_typenames) }
> - .debug_varnames 0 : { *(.debug_varnames) }
> -
> - /DISCARD/ : { *(.note.GNU-stack) }
> - /DISCARD/ : { *(.branch_lt) }
> - /DISCARD/ : { *(.data .data.* .gnu.linkonce.d.*) }
> - /DISCARD/ : { *(.bss .sbss .dynbss .dynsbss) }
> + . = VDSO64_LBASE + SIZEOF_HEADERS;
> +
> + .hash : { *(.hash) } :text
> + .gnu.hash : { *(.gnu.hash) }
> + .dynsym : { *(.dynsym) }
> + .dynstr : { *(.dynstr) }
> + .gnu.version : { *(.gnu.version) }
> + .gnu.version_d : { *(.gnu.version_d) }
> + .gnu.version_r : { *(.gnu.version_r) }
> +
> + .note : { *(.note.*) } :text :note
> +
> + . = ALIGN(16);
> + .text : {
> + *(.text .stub .text.* .gnu.linkonce.t.*)
> + *(.sfpr .glink)
> + } :text
> + PROVIDE(__etext = .);
> + PROVIDE(_etext = .);
> + PROVIDE(etext = .);
> +
> + . = ALIGN(8);
> + __ftr_fixup : { *(__ftr_fixup) }
> +
> + . = ALIGN(8);
> + __fw_ftr_fixup : { *(__fw_ftr_fixup) }
> +
> + /*
> + * Other stuff is appended to the text segment:
> + */
> + .rodata : { *(.rodata .rodata.* .gnu.linkonce.r.*) }
> + .rodata1 : { *(.rodata1) }
> +
> + .eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr
> + .eh_frame : { KEEP (*(.eh_frame)) } :text
> + .gcc_except_table : { *(.gcc_except_table) }
> +
> + .opd ALIGN(8) : { KEEP (*(.opd)) }
> + .got ALIGN(8) : { *(.got .toc) }
> + .rela.dyn ALIGN(8) : { *(.rela.dyn) }
> +
> + .dynamic : { *(.dynamic) } :text :dynamic
> +
> + _end = .;
> + PROVIDE(end = .);
> +
> + /*
> + * Stabs debugging sections are here too.
> + */
> + .stab 0 : { *(.stab) }
> + .stabstr 0 : { *(.stabstr) }
> + .stab.excl 0 : { *(.stab.excl) }
> + .stab.exclstr 0 : { *(.stab.exclstr) }
> + .stab.index 0 : { *(.stab.index) }
> + .stab.indexstr 0 : { *(.stab.indexstr) }
> + .comment 0 : { *(.comment) }
> +
> + /*
> + * DWARF debug sections.
> + * Symbols in the DWARF debugging sections are relative to the beginning
> + * of the section so we begin them at 0.
> + */
> + /* DWARF 1 */
> + .debug 0 : { *(.debug) }
> + .line 0 : { *(.line) }
> + /* GNU DWARF 1 extensions */
> + .debug_srcinfo 0 : { *(.debug_srcinfo) }
> + .debug_sfnames 0 : { *(.debug_sfnames) }
> + /* DWARF 1.1 and DWARF 2 */
> + .debug_aranges 0 : { *(.debug_aranges) }
> + .debug_pubnames 0 : { *(.debug_pubnames) }
> + /* DWARF 2 */
> + .debug_info 0 : { *(.debug_info .gnu.linkonce.wi.*) }
> + .debug_abbrev 0 : { *(.debug_abbrev) }
> + .debug_line 0 : { *(.debug_line) }
> + .debug_frame 0 : { *(.debug_frame) }
> + .debug_str 0 : { *(.debug_str) }
> + .debug_loc 0 : { *(.debug_loc) }
> + .debug_macinfo 0 : { *(.debug_macinfo) }
> + /* SGI/MIPS DWARF 2 extensions */
> + .debug_weaknames 0 : { *(.debug_weaknames) }
> + .debug_funcnames 0 : { *(.debug_funcnames) }
> + .debug_typenames 0 : { *(.debug_typenames) }
> + .debug_varnames 0 : { *(.debug_varnames) }
> +
> + /DISCARD/ : {
> + *(.note.GNU-stack)
> + *(.branch_lt)
> + *(.data .data.* .gnu.linkonce.d.* .sdata*)
> + *(.bss .sbss .dynbss .dynsbss)
> + }
> }
>
> +/*
> + * Very old versions of ld do not recognize this name token; use the constant.
> + */
> +#define PT_GNU_EH_FRAME 0x6474e550
> +
> +/*
> + * We must supply the ELF program headers explicitly to get just one
> + * PT_LOAD segment, and set the flags explicitly to make segments read-only.
> + */
> PHDRS
> {
> - text PT_LOAD FILEHDR PHDRS FLAGS(5); /* PF_R|PF_X */
> - note PT_NOTE FLAGS(4); /* PF_R */
> - dynamic PT_DYNAMIC FLAGS(4); /* PF_R */
> - eh_frame_hdr 0x6474e550; /* PT_GNU_EH_FRAME, but ld doesn't match the name */
> + text PT_LOAD FILEHDR PHDRS FLAGS(5); /* PF_R|PF_X */
> + dynamic PT_DYNAMIC FLAGS(4); /* PF_R */
> + note PT_NOTE FLAGS(4); /* PF_R */
> + eh_frame_hdr PT_GNU_EH_FRAME;
> }
>
> /*
> @@ -111,17 +125,22 @@ PHDRS
> */
> VERSION
> {
> - VDSO_VERSION_STRING {
> - global:
> - __kernel_datapage_offset; /* Has to be there for the kernel to find */
> - __kernel_get_syscall_map;
> - __kernel_gettimeofday;
> - __kernel_clock_gettime;
> - __kernel_clock_getres;
> - __kernel_get_tbfreq;
> - __kernel_sync_dicache;
> - __kernel_sync_dicache_p5;
> - __kernel_sigtramp_rt64;
> - local: *;
> - };
> + VDSO_VERSION_STRING {
> + global:
> + /*
> + * Has to be there for the kernel to find
> + */
> + __kernel_datapage_offset;
> +
> + __kernel_get_syscall_map;
> + __kernel_gettimeofday;
> + __kernel_clock_gettime;
> + __kernel_clock_getres;
> + __kernel_get_tbfreq;
> + __kernel_sync_dicache;
> + __kernel_sync_dicache_p5;
> + __kernel_sigtramp_rt64;
> +
> + local: *;
> + };
> }
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...abs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists