[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071016142121.GA21431@srcf.ucam.org>
Date: Tue, 16 Oct 2007 15:21:21 +0100
From: Matthew Garrett <mjg59@...f.ucam.org>
To: Henrique de Moraes Holschuh <hmh@....eng.br>
Cc: Jeremy Katz <katzj@...hat.com>, linux-kernel@...r.kernel.org,
torvalds@...ux-foundation.org, davej@...hat.com,
Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH] Map volume and brightness events on thinkpads
On Tue, Oct 16, 2007 at 12:11:53PM -0200, Henrique de Moraes Holschuh wrote:
> On Tue, 16 Oct 2007, Matthew Garrett wrote:
> > are sent via the keyboard controller, such as the wireless and touchpad
> > disable keys on my HP. There are Dells that do the same for brightness
>
> It is not clear to me if they are notifications or not. Does the firmware
> act on the keys by itself? If it does, then they are notifications. If it
> does not, then they are regular hot keys and there is no controversy whether
> they belong on the input layer or not (they do).
Yes, the firmware acts upon it.
> 2. I am against sending notification events through input **that look
> exactly the same as regular events**. That is not a wise design choice IMO,
> it is a very dirty hack.
Userspace is going to have to deal with this case anyway. Some vendors
simply don't let us distinguish.
> 3. We have a backlight class, a LED class, a rf-kill class and ALSA mixers.
> Is there a real reason to pester Dmitry about the issue, if we can use these
> alternate paths (that are indeed more generic and more suited for the job)?
It's not always going to be possible to tie notifications into a class
device - in the Dell case, for instance, interacting with the backlight
requires you to use a 200Kb library so has to be done in userspace.
--
Matthew Garrett | mjg59@...f.ucam.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists