[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1192496879.6118.157.camel@localhost>
Date: Mon, 15 Oct 2007 18:07:59 -0700
From: Dave Hansen <haveblue@...ibm.com>
To: Matt Mackall <mpm@...enic.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org,
Rusty Russell <rusty@...tcorp.com.au>,
Jeremy Fitzhardinge <jeremy@...p.org>,
David Rientjes <rientjes@...gle.com>,
Fengguang Wu <wfg@...l.ustc.edu.cn>
Subject: Re: [PATCH 10/11] maps3: add /proc/kpagecount and /proc/kpageflags
interfaces
On Mon, 2007-10-15 at 19:58 -0500, Matt Mackall wrote:
>
> > For the bits that we want to export, we could also add the unoptimized
> > access functions for any that don't already have them:
> >
> > #define __ClearPageReserved(page) __clear_bit(PG_reserved, &(page)->flags)
>
> Confused. Why are we interested in clear?
We're not. I just grabbed a random line to show the non-atomic
accessors. Any actual one we'd need to add would be:
#define __PageBuddy(page) __test_bit(PG_buddy, &(page)->flags)
It looks like we don't have any of these non-atomic ones for plain
__PageFoo(). So, we'd have to add them for each one that we wanted.
Still not much work, and still satisfies the "grep test". :)
-- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists