| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Oct 2007 20:24:01 +0200 From: Willy Tarreau <w@....eu> To: Pete Zaitcev <zaitcev@...hat.com> Cc: Vitaliy Ivanov <vitalivanov@...il.com>, gregkh@...e.de, linux-usb-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4. On Tue, Oct 16, 2007 at 10:56:03AM -0700, Pete Zaitcev wrote: > On Tue, 16 Oct 2007 17:41:38 +0200, Willy Tarreau <w@....eu> wrote: > > > OK, I have no objection, but please apply the fixes the le16 problem as > > suggested by Pete and Greg first. Also, you will probably receive more > > comments, and/or criticisms from further reviews. This is normal and > > expected. You just have to fix your code so that it can be merged. > > I do not object to the driver (with byte order fixed), although it seems > written oddly... E.g. lots of trivial comments, the open count locked > by wrong lock. But I do not want to hold the 2.4 version hostage to > errors of the mainline. We should've caught them when we merged adutux > into Greg's tree. I have to admit I'm skipping reviewing a lot of 2.6. I really appreciate your position, Pete. It's fair and motivating for newcomers. I hope Vitalyi will be able to forward-port some fixes and cleanups to 2.6 in the future. Thanks, Willy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists