linux-kernel - Re: RocketPort Linux driver errors on module reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Oct 2007 23:19:28 +0200
From:	"Jiri Slaby" <jirislaby@...il.com>
To:	"Wagner Ferenc" <wferi@...f.hu>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: RocketPort Linux driver errors on module reload

On 10/16/07, Wagner Ferenc <wferi@...f.hu> wrote:
> Jiri Slaby <jirislaby@...il.com> writes:
>
> > Anyway the driver faces another problem with pci refcounting (it
> > doesn't increment the counter) and the device might be removed from
> > it any time the pci bus code decides.
>
> That doesn't sound too good...  Do you mean the module could stop
> working any time, even if its devices are being used continuously?

Hmm, nobody holds the reference according to the current
implementation, so the pci layer doesn't know that anybody is working
with it.

> > Are you willing to test to-pci-probing patches (i.e. patches which
> > converts the driver to the model introduced in linux 2.4)?
>
> Well yes.  We've got a copule of such cards, which raises some
> interest in a proper driver.  Just send the patches with some
> instructions along, or point me to a git branch if you prefer.

Maybe the git with stand-alone module would be better...

> > If not, I'll only increment the counter on modprobe and decrement it
> > on rmmod, since it would be a safe (in the meaning of not changing
> > that much code) way of fixing the problem.
>
> And what are the drawbacks of this simple solution?

Nothing, but it's not the proper way -- just a safe fallback. But you
can still say no :).

regards,
--js
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/