linux-kernel - Re: [PATCH] SPARC64: fix iommu sg chaining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071017084528.GI5043@kernel.dk>
Date:	Wed, 17 Oct 2007 10:45:28 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	David Miller <davem@...emloft.net>
Cc:	fujita.tomonori@....ntt.co.jp, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH] SPARC64: fix iommu sg chaining

On Wed, Oct 17 2007, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Wed, 17 Oct 2007 01:33:25 -0700 (PDT)
> 
> > sg_next() gives you a NULL after the last entry, but tests have been
> > changed to compare against sg_last() which is likely not what we
> > want for those checks.
> 
> This of course isn't true, ignore me as I'm still learning how this
> new stuff works :-)

Righto, it's invalid to call sg_next() on the last entry! Let me know if
you need any help with debugging this, unfortunately I cannot test on
sparc64 myself...

(I can say that easily, since I know that davem will a) not rest until
this is fixed, and b) is a really good debugger and will not need my
help)

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/