linux-kernel - Re: [PATCH -mm -v5 0/3] i386/x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p73k5pmxfdw.fsf@crumb.suse.de>
Date:	17 Oct 2007 11:24:43 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"Huang, Ying" <ying.huang@...el.com>
Cc:	Andi Kleen <andi@...stfloor.org>, "H. Peter Anvin" <hpa@...or.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	akpm@...ux-foundation.org, Yinghai Lu <yhlu.kernel@...il.com>,
	Chandramouli Narayanan <mouli@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm -v5 0/3] i386/x86_64 boot: 32-bit boot protocol

"Huang, Ying" <ying.huang@...el.com> writes:

> On Wed, 2007-10-17 at 10:25 +0200, Andi Kleen wrote:
> > "Huang, Ying" <ying.huang@...el.com> writes:
> > 
> > > Do you think it is a good idea to check the collision between setup data
> > > and memory area used during kernel boot through bootmem allocator?
> > 
> > You can't solve this through bootmem because x86-64 allocates memory
> > in several places before bootmem (using functions in e820.c) Right now
> > this is quite hackish with hard coded areas to avoid conflicts.  But I
> > recently had a need to allocate more memory that early too and changed
> > the code to a generic early reservation interface. With that it would
> > be relatively easy to reserve.
> 
> Can you tell me what that early reservation interface is? What I find in
> x86_64 that does early memory allocation is alloc_low_page, which gets
> non-conflict memory area through e820 map.

It's a new interface I only recently wrote:

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/early-reserve

Then you can use early_reserve() and the e820 allocator will not touch
it.

> Because setup data is allocated by bootloader or kernel 16-bit setup
> code, and the e820 map is created there too, the memory area used by
> setup data can be made reserved memory area in e820 map by bootloader or
> kernel 16-bit setup code. This way, they will not be overwritten by
> kernel. Do you think this works.

It has a little of a chicken'n'egg problem because the e820 map will
be actually in the area you want to reserve. But it might work too.
Boot data is normally copied before other allocations in head64.c
If you do variable size boot data that might not work though.  And might
be a little fragile overall.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/