linux-kernel - Re: [PATCH] tty_ioctl: Fix the baud_table check in encode_baud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071017114358.3d2b166f@the-village.bc.nu>
Date:	Wed, 17 Oct 2007 11:43:58 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Maciej W. Rozycki" <macro@...ux-mips.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty_ioctl: Fix the baud_table check in encode_baud_rate

On Tue, 16 Oct 2007 19:12:11 +0100 (BST)
"Maciej W. Rozycki" <macro@...ux-mips.org> wrote:

>  The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has 
> a problem with the baud_table within.  The comparison operators are 
> reversed and as a result this table's entries never match and BOTHER is 
> always used.

Oops. I thought I'd fixed that one. Bit bothersome its been in -mm that
long before anyone noticed. 

ACK the first bit.

>  Additionally this function's prototype is not exported unlike the 
> function itself.

That bit seems out of date and a prototype was added later in -mm

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/