[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1192634645.17527.134.camel@imap.mvista.com>
Date: Wed, 17 Oct 2007 08:24:05 -0700
From: Daniel Walker <dwalker@...sta.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Remy Bohmer <linux@...mer.net>, Ingo Molnar <mingo@...e.hu>,
LKML <linux-kernel@...r.kernel.org>,
RT <linux-rt-users@...r.kernel.org>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RT] seqlocks: use of PICK_FUNCTION breaks kernel compile when
CONFIG_GENERIC_TIME is NOT set
On Wed, 2007-10-17 at 11:10 -0400, Steven Rostedt wrote:
> > >
> > > #define read_seqbegin_irqsave(lock, flags) \
> > > -do { \
> > > +({ \
> > > flags = PICK_SEQ_OP_RET(__read_seqbegin_irqsave_raw, \
> > > __read_seqbegin_irqsave, lock); \
> > > -} while (0)
> > > + read_seqbegin(lock); \
> > > +})
>
> Yes, definitely the raw and unraw functions should be called
> local_irqsave_raw or something else that makes this obvious to what it
> is doing.
Hmm.. I'm not sure what else to name them .. Since it's in the seqlock.h
I don't think it should be called anything "local_irq*" .. It could be
seq_irqsave_{raw} .
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists