linux-kernel - Re: suspicious ALSA empty commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0943d9e0710171319n180f05f1ta391e972a6a7efe9@mail.gmail.com>
Date:	Wed, 17 Oct 2007 21:19:39 +0100
From:	"Catalin Marinas" <catalin.marinas@...il.com>
To:	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	"Jaroslav Kysela" <perex@...ex.cz>,
	"David Miller" <davem@...emloft.net>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	krzysztof.h1@...pl
Subject: Re: suspicious ALSA empty commit

On 17/10/2007, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> On Wed, 17 Oct 2007, Jaroslav Kysela wrote:
> > I'm using stg on top of git for merging and easy tree rebasing, but the
> > version might be old (I'll try upgrade at first):
>
> Ahh. That may explain it. stg may well be using the low-level git internal
> commands (which *do* allow you to create any kind of commits you want,
> including bogus empty ones).

StGIT indeed creates empty commits (don't think there is anything
wrong with that specific version). Even the most basic command, "stg
new", creates an empty commit which is than filled with changes via
"stg refresh". Pushing patches may result in empty commits if a patch
was merged upstream. Failing import also leaves an empty commit if the
patch doesn't apply cleanly (and there is a .stgit-failed.patch file
left).

The "stg series -e" shows the empty patches and "stg clean" removes
them but I wouldn't do this automatically as empty patches are allowed
in StGIT, though in general for a limited time. I'll try to add
warning/error to commands like "mail" or "export" to make the user
aware.

-- 
Catalin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/