linux-kernel - Re: [PATCH] Map volume and brightness events on thinkpads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071017204250.GA13377@khazad-dum.debian.net>
Date:	Wed, 17 Oct 2007 18:42:50 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jeremy Katz <katzj@...hat.com>, linux-kernel@...r.kernel.org,
	davej@...hat.com
Subject: Re: [PATCH] Map volume and brightness events on thinkpads

On Wed, 17 Oct 2007, Dmitry Torokhov wrote:
> > The use of the same path for notifications and events are already a big
> > enough concession to the HAL model.  AFAIK, HAL is the only reason why on
> > most systems the userspace consumer of events and notification events are
> > the same.  HAL gets them all (as well as ACPI events, and whatever else its
> > helpers poll the system for), and then distributes them over to various
> > other paths.
> 
> I have a nagging feeling that we rely on HAL and windows environments
> too much nowadays. Last night I tried to susped my laptop while at KDM
> prompt but apparently some service is only running in context of user
> session and so nothing was there to recognize that suspend button was
> pressed (Fedora 8).

Hrnf, you are not the only one.

> That was not my primary goal. We have bitmaps of supported events in
> input_dev structure. If we were to reuse KEY_* constants for EV_NOTIFY
> then I have to make this bitmap the same size as input_dev->keybit,
> which is 512 bit at the moment (and I am thinking that we do need to
> extend it to 1024). I expect that we need much less KEY_*_NOTIFY
> events so that we could easily fit them into 32 bits.

This would be a good reason to limit what can be a notification event, yes,
since it will increase the size of every input device.

> > I'd rather we added an EV_NOTIFY *bit* that gets or-ed to the real EV_*
> > type, so that one can turn any event into a notification.  This is certainly
> > to be useful at least for EV_KEY and EV_SWITCH.
> 
> The problem with this scenario is that userspace can never be sure if
> input device is capable of only KEY_BLAH, only KEY_BLAH_NOTIFY or
> both. Normally we let userspace query device for all supported events.

Everything capable of EV_foo would be able to issue EV_foo notifications.
While this is not optimal, it is probably good enough.  Still, I was
thinking about it, and a doubt came to mind: would it cause problems for a
bitmap to share the function for EV_foo and EV_foo notifications?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/