lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Oct 2007 00:13:14 +0200 From: Pavel Machek <pavel@....cz> To: Valdis.Kletnieks@...edu Cc: Yi Yang <yang.y.yi@...il.com>, linux-kernel@...r.kernel.org, akpm@...l.org, mj@...ey.karlin.mff.cuni.cz, crutcher+kernel@...astacks.com, schwab@...e.de Subject: Re: [PATCH 2.6.23] SysRq: print hotkey info while pressing undef key, try 2 Hi! > > SysRq has already provided a similiar help before this patch, but it > > is not so clear that the user doesn't know what happened and what > > he/she should do. > > The person is in one of two states: > > 1) He has been told "recreate the problem, hit alt-sysreq-cokebottle, > and send me the results". He has a mission, and the only feedback he > needs is (a) that he hit cokebottle and not pepsibottle, and (b) the > resulting output. > > 2) He's already read the file in Documentation/ and just needs a reminder. > In this case, the fact it's only 2 or 3 lines and doesn't scroll other stuff > out of sight is more important. > > > In addition, that funtion has a big loop with another big loop > > embedded which is very inefficient, it is intended to skip some hot > > You're optimizing code that hopefully never gets executed, and even if > it does, you have the optimization *backwards*. If you're worried > about Pretty much exact. Thanks for saying this so nicely. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists