linux-kernel - Re: [PATCH] missing include in mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071017032139.17D6323A687@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
Date:	Tue, 16 Oct 2007 20:21:38 -0700
From:	David Brownell <david-b@...bell.net>
To:	viro@....linux.org.uk
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] missing include in mmc

> > > AFAICS, fallout from repacing include of blkdev.h with include of bio.h.
> > 
> > Out of curiousity, which architecture(s) need this?
>
> Umm...   IIRC, m32r had been the first build to step into that, at which point
> the missing include had been added; the rest had reached that point later, so
> I'm not sure which ones would trigger the same crap.  Not hard to test,
> though...
>
> Aha.  m68k as well.

FWIW this driver originally started out on ColdFire (m68k derived),
a few years back.  :)

Every time I seee a case where architectures don't act the same
with respect to #includes, I count it as an unpleasant surprise.
Not one that's very easy to avoid, unfortunately, but I think it's
been happening less often lately.

Thanks for the fix.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/