linux-kernel - Re: [PATCH/RFA] sch_generic: fix carrier-on bug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071017.232605.74748149.davem@davemloft.net>
Date:	Wed, 17 Oct 2007 23:26:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH/RFA] sch_generic: fix carrier-on bug?

From: Jeff Garzik <jeff@...zik.org>
Date: Tue, 16 Oct 2007 17:55:55 -0400

> While looking at a net driver with the following construct,
> 
> 	if (!netif_carrier_ok(dev))
> 		netif_carrier_on(dev);
> 
> it stuck me that the netif_carrier_ok() check was redundant, since
> netif_carrier_on() checks bit __LINK_STATE_NOCARRIER anyway.  This is
> the same reason why netif_queue_stopped() need not be called prior to
> netif_wake_queue().
> 
> This is true, but there is however an unwanted side effect from assuming
> that netif_carrier_on() can be called multiple times:  it touches the
> watchdog, regardless of pre-existing carrier state.
> 
> The fix:  move watchdog-up inside the bit-cleared code path.
> 
> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>

I see no problems with this patch, I'll apply it, thanks!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/