linux-kernel - RE: [PATCH 5/5] I/OAT: Add completion callback for async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BAE9DCEF64577A439B3A37F36F9B691C033FE9B1@orsmsx418.amr.corp.intel.com>
Date:	Wed, 17 Oct 2007 17:53:00 -0700
From:	"Nelson, Shannon" <shannon.nelson@...el.com>
To:	"David Miller" <davem@...emloft.net>, <akpm@...ux-foundation.org>
Cc:	<linux-kernel@...r.kernel.org>, <torvalds@...ux-foundation.org>,
	"Williams, Dan J" <dan.j.williams@...el.com>,
	<randy.dunlap@...cle.com>
Subject: RE: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use

>From: David Miller [mailto:davem@...emloft.net] 
>
>From: Andrew Morton <akpm@...ux-foundation.org>
>Date: Wed, 17 Oct 2007 17:44:38 -0700
>
>> On Wed, 17 Oct 2007 17:14:39 -0700
>> Shannon Nelson <shannon.nelson@...el.com> wrote:
>> 
>> > +	tx->callback = (void *)ioat_dma_test_callback;
>> 
>> and when I remove this cast I get
>> 
>> drivers/dma/ioat_dma.c: In function 'ioat_dma_self_test':
>> drivers/dma/ioat_dma.c:718: warning: assignment from 
>incompatible pointer type
>> 
>> because ioat_dma_test_callback isn't void-returning.  
>Something is wrong
>> here.  I assume that ioat_dma_test_callback() should just be
>> void-returning?
>
>In fact this might crash on systems that conditionally pop
>return values based upon whether the function is void or not.
>

Yep - thanks.  That's my misuse of Dan's dma_async_tx_callback typedef.

sln
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/