linux-kernel - Re: [RFC] [PATCH -mm] ASIC3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.9999.0710190013420.22770@localhost.localdomain>
Date:	Fri, 19 Oct 2007 00:15:47 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Samuel Ortiz <sameo@...nedhand.com>, linux-kernel@...r.kernel.org,
	Paul Sokolovsky <pmiscml@...il.com>,
	Ben Dooks <ben@...nity.fluff.org>
Subject: Re: [RFC] [PATCH -mm] ASIC3 driver

On Thu, 18 Oct 2007, Andrew Morton wrote:
> > +
> > +#include <linux/module.h>
> > +#include <linux/version.h>
> > +#include <linux/irq.h>
> 
> Please see the large comment at the top of linux/irq.h.  I believe this
> driver will fial to compile on at least arm.
> 
> We really should fix this.

drivers are fine with: #include <linux/interrupt.h>

If they need linux/irq.h, then they do probably something really
nasty.

   	tglx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/