lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4716C418.6090708@rtr.ca> Date: Wed, 17 Oct 2007 22:25:28 -0400 From: Mark Lord <lkml@....ca> To: Kristen Carlson Accardi <kristen.c.accardi@...el.com> Cc: Linux Kernel <linux-kernel@...r.kernel.org>, Greg KH <greg@...ah.com>, Andrew Morton <akpm@...ux-foundation.org>, Theodore Tso <tytso@....edu>, pcihpd-discuss@...ts.sourceforge.net Subject: Re: [Pcihpd-discuss] [PATCH 2/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2) Kristen Carlson Accardi wrote: > On Tue, 16 Oct 2007 21:54:42 -0400 > Mark Lord <lkml@....ca> wrote: > >> Fix pciehp_probe() to deal with pre-inserted ExpressCard cards, >> but only when pciehp_force==1. Otherwise behaviour is unmodified. > > I think it would be ok to try allowing the slot to be enabled when not > using pciehp_force mode. We can wrap it later if it proves to break > things, however, see my comment below: Could you test that on ACPI-supported hardware and report back, please. ... > Here it seems like what you want to do just go ahead and try to call > pciehp_enable_slot always, but check the return value. If an adapter is > not present, it will return -ENODEV, and then you can check to see if > you have the ability to power off the slot, and try to power it off. Okay, will do. > Please fix CodingStyle issues too. ???? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists