linux-kernel - Re: latest checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071019090115.GE21136@shadowen.org>
Date:	Fri, 19 Oct 2007 10:01:15 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Avi Kivity <avi@...ranet.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: latest checkpatch

On Thu, Oct 18, 2007 at 10:51:47PM +0200, Ingo Molnar wrote:
> 
> * Avi Kivity <avi@...ranet.com> wrote:
> 
> > >> 	if (foo)
> > >> 		bar();
> > >> 		baz();
> > >> 	one();
> > >>     
> > >
> > > detecting that would be awesome - it's often the sign of a real bug 
> > > because the intent is often to have bar() and baz() in the conditional 
> > > block.
> > 
> > This is more useful operating on an entire file, so the script can see 
> > all the context.
> 
> there's "checkpatch --file" for complete files, so it can see the full 
> context if the user passes it in.

Indeed so.  checkpatch uses all the context it can when making a
decision.  Often 3 lines carries enough history to figure this out.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/