linux-kernel - fs/buffer.c:nobh_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 19 Oct 2007 15:43:00 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Nick Piggin <npiggin@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: fs/buffer.c:nobh_write_end(): NULL dereference

Commit 03158cd7eb3374843de68421142ca5900df845d9 introcduced the 
following NULL dereference:

<--  snip  -->

...
int nobh_write_end(struct file *file, struct address_space *mapping,
                        loff_t pos, unsigned len, unsigned copied,
                        struct page *page, void *fsdata)
{
        struct inode *inode = page->mapping->host;
        struct buffer_head *head = NULL;
        struct buffer_head *bh;

        if (!PageMappedToDisk(page)) {
                if (unlikely(copied < len) && !page_has_buffers(page))
                        attach_nobh_buffers(page, head);
...                                               ^^^^

<--  snip  -->

Spotted by the Coverity checker.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/