linux-kernel - Re: [PATCH 2/9] irq-remove: arch non-trivial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4718E67F.6000300@garzik.org>
Date:	Fri, 19 Oct 2007 13:16:47 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/9] irq-remove: arch non-trivial

Eric W. Biederman wrote:
> In this case we can easily pass the irqno into request_irq, allowing
> us to do "unsigned int intno = (unsigned int)dev_id;".
> 
> I suspect this is the case for the majority of the non-trivial users
> as well.

Not that easy, alas :)  Save for weirdos like the mac drivers I 
highlighted, it seems like most drivers in the non-trivial already pass 
a useful pointer to request_irq().

But as I mentioned, most of the "non-trivial" uses are actually trivial 
-- just not as simple as removing the 'int irq' argument.  Most of the 
time the irq number is used in non-critical ways like printk's.  A few 
times its used to index into a structure (something dev_id could replace).

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/