linux-kernel - Re: [PATCH 1/9] irq-remove: core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4718EDFE.40401@garzik.org>
Date:	Fri, 19 Oct 2007 13:48:46 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] irq-remove: core

Eric W. Biederman wrote:
> Jeff Garzik <jeff@...zik.org> writes:
> 
>> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
>> index 80eab7a..92e1456 100644
>> --- a/kernel/irq/manage.c
>> +++ b/kernel/irq/manage.c
>> @@ -455,7 +455,7 @@ void free_irq(unsigned int irq, void *dev_id)
>>  			 */
>>  			if (action->flags & IRQF_SHARED) {
>>  				local_irq_save(flags);
>> -				action->handler(irq, dev_id);
>> +				action->handler(dev_id);
>>  				local_irq_restore(flags);
>>  			}
>>  #endif
>> @@ -549,7 +549,7 @@ int request_irq(unsigned int irq, irq_handler_t handler,
>>  		unsigned long flags;
>>  
>>  		local_irq_save(flags);
>> -		handler(irq, dev_id);
>> +		handler(dev_id);
>>  		local_irq_restore(flags);
>>  	}
>>  #endif
> 
> The above two hunks need to call set_irqfunc_irq in your model.

Duh.  Thanks for pointing out an obvious mistake :)

Fixed and checked into 'irq-remove' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/