linux-kernel - Re: [RFC] [PATCH -mm] ASIC3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071019110034.1534bb86.akpm@linux-foundation.org>
Date:	Fri, 19 Oct 2007 11:00:34 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Samuel Ortiz <sameo@...nedhand.com>
Cc:	linux-kernel@...r.kernel.org, Paul Sokolovsky <pmiscml@...il.com>,
	Ben Dooks <ben@...nity.fluff.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC] [PATCH -mm] ASIC3 driver

On Fri, 19 Oct 2007 12:53:00 +0200 Samuel Ortiz <sameo@...nedhand.com> wrote:

> On Thu, Oct 18, 2007 at 03:05:44PM -0700, Andrew Morton wrote:
> > On Thu, 18 Oct 2007 11:12:41 +0200
> > Samuel Ortiz <sameo@...nedhand.com> wrote:
> 
> > > +#include <linux/module.h>
> > > +#include <linux/version.h>
> > > +#include <linux/irq.h>
> > 
> > Please see the large comment at the top of linux/irq.h.  I believe this
> > driver will fial to compile on at least arm.
> It doesn't build as a module, since we need the irq.h symbols.
> I changed MFD_ASIC3 to bool. I somehow feel that this is not the cleanest
> solution, but OTOH I think that dynamically adding IRQs and GPIOs to an
> embedded board doesn't make much sense.

We seem to have miscommunicated here.  <linux/irq.h> contains references to
things which only some architectures actually implement.  I don't know
which architectures those are, but it includes common ones like x86, so
it's a real trap.  I recall it does not include arm, so your code might
break on arm.

At least, that's what's _supposed_ to happen: I just compiled and linked
this driver into an ARM kernel with no problems so now I'm all confused as
to what the problem was.

Oh well, we'll see...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/