linux-kernel - Re: [NFS] [GIT] NFS client fixes for 2.6.23++

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1192900957.7440.10.camel@heimdal.trondhjem.org>
Date:	Sat, 20 Oct 2007 13:22:37 -0400
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Erez Zadok <ezk@...sunysb.edu>, nfs@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [NFS] [GIT] NFS client fixes for 2.6.23++


On Fri, 2007-10-19 at 19:32 -0700, Linus Torvalds wrote:
> 
> On Fri, 19 Oct 2007, Erez Zadok wrote:
> > 
> > Trond, with Linus's latest tree, you need to #include <linux/sched.h> in
> > fs/nfs/unlink.c, else I get:
> > 
> >   CC [M]  fs/nfs/unlink.o
> > fs/nfs/unlink.c: In function 'nfs_dec_sillycount':
> > fs/nfs/unlink.c:67: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
> ...
> 
> Hmm? Which architecture?
> 
> That said, I do think that there is a distinct lack of proper includes in 
> that file. It seems to depend on getting much of the includes indirectly 
> from <linux/nfs_fs.h> and friends. And with different architectures having 
> different header files..
> 
> 		Linus

This ought to fix it.
----------------------------------------------------
From: Trond Myklebust <Trond.Myklebust@...app.com>
Date: Sat, 20 Oct 2007 13:21:04 -0400
NFS: Fix the include files needed by fs/nfs/unlink.c

Signed-off-by: Trond Myklebust <Trond.Myklebust@...app.com>
---

 fs/nfs/unlink.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/unlink.c b/fs/nfs/unlink.c
index 6ecd46c..057e6ce 100644
--- a/fs/nfs/unlink.c
+++ b/fs/nfs/unlink.c
@@ -5,9 +5,14 @@
  *
  */
 
+#include <asm/atomic.h>
+#include <linux/dcache.h>
 #include <linux/slab.h>
 #include <linux/string.h>
-#include <linux/dcache.h>
+#include <linux/sched.h>
+#include <linux/spinlock.h>
+#include <linux/wait.h>
+#include <linux/sunrpc/auth.h>
 #include <linux/sunrpc/sched.h>
 #include <linux/sunrpc/clnt.h>
 #include <linux/nfs_fs.h>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/