linux-kernel - Re: [PATCH] xconfig: set title bar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071020183009.GB8334@uranus.ravnborg.org>
Date:	Sat, 20 Oct 2007 20:30:09 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	lkml <linux-kernel@...r.kernel.org>, zippel@...ux-m68k.org,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH] xconfig: set title bar

On Sat, Oct 20, 2007 at 11:18:47AM -0700, Randy Dunlap wrote:
> On Sat, 20 Oct 2007 19:14:03 +0200 Sam Ravnborg wrote:
> 
> > I found this one to work:
> > +       setCaption("hello my little world");
> 
> Thanks, your search expressions were better than mine.
> 
> > We should show the prompt associated with mainmenu here.
> 
> You want all 3 of them converted to
> 	symbol_value(mainmenu) + $KERNELVERSION

Well - if mainmenu should serve any purpose then yes.


> ?
> 
> ---
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Put kernel version info on title bar in xconfig (qconf) instead of
> defaulting to "qconf".
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  scripts/kconfig/qconf.cc |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- linux-2.6.23-git13.orig/scripts/kconfig/qconf.cc
> +++ linux-2.6.23-git13/scripts/kconfig/qconf.cc
> @@ -1274,8 +1274,12 @@ ConfigMainWindow::ConfigMainWindow(void)
>  	QMenuBar* menu;
>  	bool ok;
>  	int x, y, width, height;
> +	char title[256];
>  
>  	QWidget *d = configApp->desktop();
> +	sprintf(title, _("Linux Kernel v%s Configuration"),

I made this look like this:
> +	snprintf(title, sizeof(title), _("Linux Kernel v%s Configuration"),

because we may append to the KERNELVERSION using EXTRAVERSION and people could go insane.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/