linux-kernel - Re: kbuild: disable depmod in cross-compile kernel build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071022094917.GA12064@uranus.ravnborg.org>
Date:	Mon, 22 Oct 2007 11:49:17 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Christian Bjølevik <nafallo@...icalforest.se>,
	Deepak Saxena <dsaxena@...sta.com>,
	Armin Kuster <akuster@...sta.com>,
	Adrian Bunk <bunk@...nel.org>
Subject: Re: kbuild: disable depmod in cross-compile kernel build

> 
> Euh, is these really necessary?
> 
> At work I have no problems running depmod on an i386 system for ppc64 modules
> after I installed module-init-tools 3.3-pre2 (from Debian).
> I did have problems (depmod SEGV) using the depmod that came with CentOS
> 4 (from module-init-tools 3.1-pre5).

The patch was solely done due to people complaining and I even had a bugzilla
entry about it.
I expext Armin or Christian to speak up if this is a real problem for them.

PS. I did not do a revert since the original patch contained a nice cleanup.

	Sam

I have just committed the following:

>From d2c83557493c8595e2d3f31d0469bcf43d19b560 Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <sam@...tun.(none)>
Date: Mon, 22 Oct 2007 11:30:45 +0200
Subject: [PATCH] kbuild: allow depmod in cross builds again

depmod from module-init-tools 3.3-pre2 are reported
to work fine in cross build.
depmod from module-init-tools 3.1-pre5 are know to SEGV

Do not workaround older module-init-tools bug here.
The right fix is for users to upgrade module-init-tools.

Signed-off-by: Sam Ravnborg <sam@...nborg.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index f4238b2..264f37b 100644
--- a/Makefile
+++ b/Makefile
@@ -1505,7 +1505,7 @@ quiet_cmd_rmfiles = $(if $(wildcard $(rm-files)),CLEAN   $(wildcard $(rm-files))
 # and we build for the host arch
 quiet_cmd_depmod = DEPMOD  $(KERNELRELEASE)
       cmd_depmod = \
-	if [ -r System.map -a -x $(DEPMOD) -a "$(SUBARCH)" = "$(ARCH)" ]; then \
+	if [ -r System.map -a -x $(DEPMOD) ]; then                              \
 		$(DEPMOD) -ae -F System.map                                     \
 		$(if $(strip $(INSTALL_MOD_PATH)), -b $(INSTALL_MOD_PATH) -r)   \
 		$(KERNELRELEASE);                                               \
-- 
1.5.3.4.1157.g0e74-dirty

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/