lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Oct 2007 04:10:31 +0200 From: Roel Kluin <12o3l@...cali.nl> To: lkml <linux-kernel@...r.kernel.org> Subject: [PATCH] unlock before bug returns I think the unlock should be before bugging? -- unlock before bug returns Signed-off-by: Roel Kluin <12o3l@...cali.nl> --- diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 5a4cc20..c910170 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach-omap2/gpmc.c @@ -357,9 +357,8 @@ void gpmc_cs_free(int cs) spin_lock(&gpmc_mem_lock); if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) { printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs); - BUG(); spin_unlock(&gpmc_mem_lock); - return; + BUG(); } gpmc_cs_disable_mem(cs); release_resource(&gpmc_cs_mem[cs]); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists