[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <84144f020710220540i7be08eednf40db8367669825f@mail.gmail.com>
Date: Mon, 22 Oct 2007 15:40:44 +0300
From: "Pekka Enberg" <penberg@...helsinki.fi>
To: "Roel Kluin" <12o3l@...cali.nl>
Cc: "Rik van Riel" <riel@...hat.com>,
lkml <linux-kernel@...r.kernel.org>,
"Christoph Lameter" <clameter@....com>
Subject: Re: [PATCH] unlock before bug returns
Hi Roel,
On 10/22/07, Roel Kluin <12o3l@...cali.nl> wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index cfa6be4..20c58dc 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1606,8 +1606,10 @@ void __init kmem_cache_init(void)
> struct kmem_cache *cachep;
> mutex_lock(&cache_chain_mutex);
> list_for_each_entry(cachep, &cache_chain, next)
> - if (enable_cpucache(cachep))
> + if (enable_cpucache(cachep)) {
> + mutex_unlock(&cache_chain_mutex);
> BUG();
> + }
> mutex_unlock(&cache_chain_mutex);
> }
NAK. This will cause double-unlock when CONFIG_BUG is disabled. It's
incorrect to assume that BUG() will always terminate the current
process.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists