[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071022024734.GI30533@stusta.de>
Date: Mon, 22 Oct 2007 04:47:34 +0200
From: Adrian Bunk <bunk@...nel.org>
To: Jiri Slaby <jirislaby@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: char/cyclades.c: inconsequent NULL checking
The Coverity checker spotted the following inconsequent NULL checking in
drivers/char/cyclades.c:
<-- snip -->
...
static void cyz_handle_tx(struct cyclades_port *info,
struct BUF_CTRL __iomem *buf_ctrl)
{
struct cyclades_card *cinfo = info->card;
struct tty_struct *tty = info->tty;
...
if (tty == NULL)
goto ztxdone;
...
tty_wakeup(tty);
...
<-- snip -->
Nothing in cyz_handle_tx() seems to change "tty".
The "tty_wakeup(tty);" was added in commit
ebafeeff0fea029099e9952f233e0794106897a6.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists