linux-kernel - Re: [PATCH 1/2] irq_flags_t: intro and core annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0710222044400.7105@anakin>
Date:	Mon, 22 Oct 2007 20:50:14 +0200 (CEST)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Ralf Baechle <ralf@...ux-mips.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Al Viro <viro@....linux.org.uk>, torvalds@...ux-foundation.org,
	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/2] irq_flags_t: intro and core annotations

On Mon, 22 Oct 2007, Andrew Morton wrote:
> On Mon, 22 Oct 2007 16:29:12 +0100 Ralf Baechle <ralf@...ux-mips.org> wrote:
> > On Sun, Oct 21, 2007 at 01:30:42PM +0400, Alexey Dobriyan wrote:
> > 
> > > 			irq_flags_t
> > > 	
> > > New type for use with spin_lock_irqsave() and friends.
> > 
> > Talking about it, why did we ever require this to be a long anyway?  I could
> > get away with a single bit for MIPS; the rest of this variable is pure
> > bloat.  An abstract datatype could help finally fix this.
> > 
> 
> Yes, it's always been ugly that we use unsigned long for this rather than
> abstracting it properly.
> 
> However I'd prefer that we have some really good reason for introducing
> irq_flags_t now.  Simply so that I don't needlessly spend the next two
> years wrestling with literally thousands of convert-to-irq_flags_t patches
> and having to type "please use irq_flags_t here" in hundreds of patch
> reviews. (snivel, wimper)

The second part can be fixed easily using
`typedef struct { long x; } irq_flags_t' ;-)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/