linux-kernel - [PATCH 1/1] Char: cyclades, fix potential NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 22 Oct 2007 15:04:44 -0400
From:	Jiri Slaby <jirislaby@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Adrian Bunk <bunk@...nel.org>
Subject: [PATCH 1/1] Char: cyclades, fix potential NULL dereference

cyclades, fix potential NULL dereference

to ztxdone is jumped even if tty is NULL and tty_wakeup placed after this
label doesn't expect NULLed parameter, so this will cause an oops in some
situations (why they scheduled a wakeup there before remove bottom half
processing patch?). wakeup only in the case when we have non-null tty
struct.
Spotted by Adrian Bunk.

Signed-off-by: Jiri Slaby <jirislaby@...il.com>
Cc: Adrian Bunk <bunk@...nel.org>

---
commit d5e700a2247a9dc66cda09e6d89d1dc284bda40b
tree e0ba44e65a2026e4cba1e158580eaf492a1bfa35
parent bd9d07361314f393c7686466687c0a7aa8e88109
author Jiri Slaby <jirislaby@...il.com> Mon, 22 Oct 2007 20:47:01 +0200
committer Jiri Slaby <jirislaby@...il.com> Mon, 22 Oct 2007 20:47:01 +0200

 drivers/char/cyclades.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c
index d15234c..710c056 100644
--- a/drivers/char/cyclades.c
+++ b/drivers/char/cyclades.c
@@ -1604,8 +1604,8 @@ static void cyz_handle_tx(struct cyclades_port *info,
 			info->icount.tx++;
 		}
 #endif
-ztxdone:
 		tty_wakeup(tty);
+ztxdone:
 		/* Update tx_put */
 		cy_writel(&buf_ctrl->tx_put, tx_put);
 	}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/