[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LFD.0.999.0710221254550.30120@woody.linux-foundation.org>
Date: Mon, 22 Oct 2007 12:56:29 -0700 (PDT)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Matthew Wilcox <matthew@....cx>
cc: Arnd Bergmann <arnd@...db.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Ralf Baechle <ralf@...ux-mips.org>,
Alexey Dobriyan <adobriyan@...il.com>,
Al Viro <viro@....linux.org.uk>, viro@...iv.linux.org.uk,
linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 1/2] irq_flags_t: intro and core annotations
On Mon, 22 Oct 2007, Matthew Wilcox wrote:
>
> We certainly don't want to encourage people to blindly make those
> conversions ... and I've seen the results of encouraging kernel janitors
> to do things a certain way.
There's another issue: the "irqsave/irqrestore" versions are much safer
than the plain "irq" versions, in case the caller already has interrupts
disabled.
So anybody making the change not only would need to make the performance
argument, he'd better not be a janitor that blindly does the change
without thinking about all call-sites etc..
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists