[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071023071641.GE24546@osiris.boeblingen.de.ibm.com>
Date: Tue, 23 Oct 2007 09:16:41 +0200
From: Heiko Carstens <heiko.carstens@...ibm.com>
To: Jens Axboe <jens.axboe@...cle.com>
Cc: torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
mingo@...e.hu, Christoph Schmitt <schmichr@...ibm.com>,
Swen Schillig <swen@...t.ibm.com>,
Martin Schwidefsky <schwidefsky@...ibm.com>,
linux-s390@...r.kernel.org
Subject: Re: [PATCH 04/10] [SG] Update drivers to use sg helpers
On Tue, Oct 23, 2007 at 09:14:07AM +0200, Jens Axboe wrote:
> On Tue, Oct 23 2007, Heiko Carstens wrote:
> > On Mon, Oct 22, 2007 at 08:10:58PM +0200, Jens Axboe wrote:
> > > Signed-off-by: Jens Axboe <jens.axboe@...cle.com>
> > > ---
> >
> > You forgot s390's zfcp driver. But unfortunately the trivial fix below
> > doesn't work. No more I/O possible. Swen and/or Christof could you
> > provide a correct fix for this please? Thanks!
> >
> > ---
> > drivers/s390/scsi/zfcp_def.h | 4 ++--
> > drivers/s390/scsi/zfcp_erp.c | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > Index: linux-2.6/drivers/s390/scsi/zfcp_def.h
> > ===================================================================
> > --- linux-2.6.orig/drivers/s390/scsi/zfcp_def.h
> > +++ linux-2.6/drivers/s390/scsi/zfcp_def.h
> > @@ -63,7 +63,7 @@
> > static inline void *
> > zfcp_sg_to_address(struct scatterlist *list)
> > {
> > - return (void *) (page_address(list->page) + list->offset);
> > + return (void *) (page_address(sg_page(list) + list->offset));
> > }
>
> return sg_virt(list); would be better.
>
> I'll fix up the driver, no worries.
ok, thanks!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists