lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Oct 2007 09:45:54 +0200 From: Jens Axboe <jens.axboe@...cle.com> To: David Miller <davem@...emloft.net> Cc: fujita.tomonori@....ntt.co.jp, linux-kernel@...r.kernel.org Subject: Re: IDE crash... On Tue, Oct 23 2007, David Miller wrote: > From: Jens Axboe <jens.axboe@...cle.com> > Date: Tue, 23 Oct 2007 09:23:59 +0200 > > > On Tue, Oct 23 2007, David Miller wrote: > > > From: Jens Axboe <jens.axboe@...cle.com> > > > Date: Tue, 23 Oct 2007 09:09:33 +0200 > > > > > > > Eh this wont work, it's the wrong entry... Here's a temporary > > > > work-around. > > > > > > > > diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c > > > > index c89f0d3..108202b 100644 > > > > --- a/drivers/ide/ide-io.c > > > > +++ b/drivers/ide/ide-io.c > > > > @@ -822,6 +822,7 @@ void ide_map_sg(ide_drive_t *drive, struct request *rq) > > > > return; > > > > > > > > if (rq->cmd_type != REQ_TYPE_ATA_TASKFILE) { > > > > + sg_init_table(hwif->sg_table, hwif->sg_max_nents); > > > > hwif->sg_nents = blk_rq_map_sg(drive->queue, rq, sg); > > > > } else { > > > > sg_init_one(sg, rq->buffer, rq->nr_sectors * SECTOR_SIZE); > > > > > > That's the exact patch I'm about to boot test :-) > > > > That should work - once you verify that, would you mind testing this one > > as well? Thanks! > > This one works here too, thanks. Great, thanks for testing that as well. Thinking a bit more about it, I think the forced clear should stay in blk_rq_map_sg() since we don't want to advertise it to drivers. So I'll just open-code it in there. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists