[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <471DC66D.6000909@garzik.org>
Date: Tue, 23 Oct 2007 06:01:17 -0400
From: Jeff Garzik <jeff@...zik.org>
To: David Miller <davem@...emloft.net>
CC: barkalow@...ervon.org, linas@...tin.ibm.com,
chunhao.huang@...mail.com, gregkh@...e.de, htejun@...il.com,
brice.goglin@...il.com, david.gaarenstroom@...il.com,
linux-kernel@...r.kernel.org, linux-pci@...ey.karlin.mff.cuni.cz,
shane.huang@....com, linux-ide@...r.kernel.org, brice@...i.com
Subject: Re: [patch] PCI: disable MSI on more ATI NorthBridges
David Miller wrote:
> My suggestion is:
>
> 1) Leave the pci_intx() twiddling code in drivers/pci/msi.c
>
> 2) Add quirks for "INTX_DISABLE turns off MSI too", this sets
> a flag in the pci_dev.
>
> 3) The pci_intx() calls in drivers/pci/msi.c are skipped if this
> flag from #2 is set.
>
> 4) Add quirk entries for drivers/net/tg3.c chips and these SATA
> devices we are learning about here, as well as any others we
> are aware of right now.
>
> 5) Remove the pci_intx() workaround code from drivers/net/tg3.c
> and elsewhere.
Sounds good to me also.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists