linux-kernel - Re: [PATCH] reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071023101053.638fe207@think.oraclecorp.com>
Date:	Tue, 23 Oct 2007 10:10:53 -0400
From:	Chris Mason <chris.mason@...cle.com>
To:	Fengguang Wu <wfg@...l.ustc.edu.cn>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Maxim Levitsky <maximlevitsky@...il.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeff Mahoney <jeffm@...e.com>, reiserfs-dev@...esys.com,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] reiserfs: don't drop PG_dirty when releasing
 sub-page-sized dirty file

On Tue, 23 Oct 2007 19:56:20 +0800
Fengguang Wu <wfg@...l.ustc.edu.cn> wrote:

> On Tue, Oct 23, 2007 at 12:07:07PM +0200, Peter Zijlstra wrote:
> > [ adding reiserfs devs to the CC ]
> 
> Thank you.
> 
> This fix is kind of crude - even when it fixed Maxim's problem, and
> survived my stress testing of a lot of patching and kernel compiling.
> I'd be glad to see better solutions.

This should be safe, reiserfs has the buffer heads themselves clean and
the page should get cleaned eventually.  The cancel_dirty_page call was
just an optimization to be VM friendly.

-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/