linux-kernel - Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071023151309.GA14998@elte.hu>
Date:	Tue, 23 Oct 2007 17:13:09 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Al Viro <viro@....linux.org.uk>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Sam Ravnborg <sam@...nborg.org>, Nix <nix@...eri.org.uk>,
	Jeff Dike <jdike@...toit.com>,
	Paolo Giarrusso <p.giarrusso@...il.com>,
	user-mode-linux-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Rob Landley <rob@...dley.net>
Subject: Re: [uml-devel] User Mode Linux still doesn't build in
	2.6.23-final.


* Andi Kleen <andi@...stfloor.org> wrote:

> On Tue, Oct 23, 2007 at 04:20:06PM +0200, Ingo Molnar wrote:
> > 
> > * Andi Kleen <andi@...stfloor.org> wrote:
> > 
> > > >> You should rename it then to "asmcall" or something.
> > > >
> > > > if then that should be a separate renaming patch.
> > > 
> > > Well you're asking for the ugly hacks for out of tree code.  [...]
> > 
> > nice word-bending there. I'm asking for pre-existing annotations to 
> > survive. 
> 
> What I'm objecting to is that you ask for this for your out of tree 
> code without any justification on why exactly -- -pg should in theory 
> work with -mregparms.

last i checked it didnt work - i'll re-check that.

but even taking the latency tracer completely out of the picture, 
maintaining this information is useful - at least for some time.

> It's standard policy to require very good reasons for changes that are 
> only useful for out of tree code. [...]

it's not just for out of tree code - it's to keep the information of the 
calling convention maintained - we could need it in the future.

> Is it just because you didn't want to adapt the tracer for i386 
> regparm? [...]

uhm, thank you for such accusations and personal attacks :-( How did i 
deserve that?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/