lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <471D3B0C.6040703@tiscali.nl> Date: Tue, 23 Oct 2007 02:06:36 +0200 From: Roel Kluin <12o3l@...cali.nl> To: lkml <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] unlock 12c_mutex before return And a similar one in drivers/media/dvb/dvb-usb/gl861.c -- unlock 12c_mutex before return -EINVAL Signed-off-by: Roel Kluin <12o3l@...cali.nl> --- diff --git a/drivers/media/dvb/dvb-usb/gl861.c b/drivers/media/dvb/dvb-usb/gl861.c index f01d99c..20c340a 100644 --- a/drivers/media/dvb/dvb-usb/gl861.c +++ b/drivers/media/dvb/dvb-usb/gl861.c @@ -59,8 +59,10 @@ static int gl861_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msg[], if (mutex_lock_interruptible(&d->i2c_mutex) < 0) return -EAGAIN; - if (num > 2) + if (num > 2) { + mutex_unlock(&d->i2c_mutex); return -EINVAL; + } for (i = 0; i < num; i++) { /* write/read request */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists