linux-kernel - Re: [git pull] lguest: paravirt boot code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Oct 2007 09:10:21 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
cc:	linux-kernel@...r.kernel.org, lguest <lguest@...abs.org>,
	virtualization@...ts.linux-foundation.org,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [git pull] lguest: paravirt boot code



On Tue, 23 Oct 2007, Rusty Russell wrote:
>
> Well, with that out the way, and some scatterlist fixups, please pull from
> 
> 	git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-lguest.git

Ok. However, please include a proper diffstat. And by proper, I mean:

	git diff -M --stat --summary

because right now your diffstat doesn't contain the final "total number of 
lines added/removed" (which is the easiest way for me to see that there 
isn't anything strange in there), and your diffstat doesn't do renames, so 
renames look like delete/create pairs. For example, you had:

>  arch/x86/lguest/boot.c                | 1070 ++++++++++++++++++++++
>  drivers/lguest/lguest.c               | 1108 ----------------------

but in reality it was not at all thousands of lines changed, but instead a 
rename with much smaller changes:

 drivers/lguest/lguest.c => arch/x86/lguest/boot.c  |  102 +-

which is a lot more readable and tells me much more about what is going 
on.

And at the end, I really do want to see the details like this:

	 70 files changed, 4822 insertions(+), 4401 deletions(-)
	 create mode 100644 arch/x86/lguest/Kconfig
	 create mode 100644 arch/x86/lguest/Makefile
	 rename drivers/lguest/lguest.c => arch/x86/lguest/boot.c (93%)
	 rename drivers/lguest/lguest_asm.S => arch/x86/lguest/i386_head.S (73%)
	 delete mode 100644 drivers/block/lguest_blk.c
	 create mode 100644 drivers/block/virtio_blk.c
	 delete mode 100644 drivers/char/hvc_lguest.c
	 create mode 100644 drivers/char/virtio_console.c
	 delete mode 100644 drivers/lguest/io.c
	 delete mode 100644 drivers/lguest/lguest_bus.c
	 create mode 100644 drivers/lguest/lguest_device.c
	 create mode 100644 drivers/lguest/x86/core.c
	 rename drivers/lguest/{switcher.S => x86/switcher_32.S} (99%)
	 delete mode 100644 drivers/net/lguest_net.c
	 create mode 100644 drivers/net/virtio_net.c
	 create mode 100644 drivers/virtio/Kconfig
	 create mode 100644 drivers/virtio/Makefile
	 create mode 100644 drivers/virtio/config.c
	 create mode 100644 drivers/virtio/virtio.c
	 create mode 100644 drivers/virtio/virtio_ring.c
	 create mode 100644 include/asm-x86/lguest.h
	 create mode 100644 include/asm-x86/lguest_hcall.h
	 delete mode 100644 include/linux/lguest_bus.h
	 create mode 100644 include/linux/virtio.h
	 create mode 100644 include/linux/virtio_blk.h
	 create mode 100644 include/linux/virtio_config.h
	 create mode 100644 include/linux/virtio_console.h
	 create mode 100644 include/linux/virtio_net.h
	 create mode 100644 include/linux/virtio_ring.h

which again gives a nice overview of what the heck is actually going on 
here. All of which you get for free if you use the above git command line.

Anyway, pulled. But just for future reference,

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/