linux-kernel - Re: [PATCH 4/4] x86 gart: rename symbols only used for the GART implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <471E37B4.9010604@zytor.com>
Date:	Tue, 23 Oct 2007 11:04:36 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Dave Jones <davej@...hat.com>, Joerg Roedel <joerg.roedel@....com>,
	Andi Kleen <ak@...e.de>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] x86 gart: rename symbols only used for the GART	implementation

Dave Jones wrote:
> On Tue, Oct 23, 2007 at 07:47:11PM +0200, Joerg Roedel wrote:
>  > On Tue, Oct 23, 2007 at 07:43:47PM +0200, Andi Kleen wrote:
>  > > On Tuesday 23 October 2007 19:41:33 Joerg Roedel wrote:
>  > > > This patch renames the 4 symbols iommu_hole_init(), iommu_aperture,
>  > > > iommu_aperture_allowed, iommu_aperture_disabled.
>  > > > 
>  > > > It replaces the iommu_ with gart_ in the symbol name. All these symbols are
>  > > > only used for the GART implementation of IOMMUs.
>  > > 
>  > > That makes it still potentially conflicting with the AGP GART code.
>  > 
>  > Maybe yes. But the AGP GART driver conflicts with the GART IOMMU config
>  > option. So I don't see a problem here.
>  
> It shouldn't.  It's perfectly feasible to use both IOMMU and GART for AGP at
> the same time.
> 

And even if did, it's a big difference between being not able to compile 
in two drivers in the same kernel and not being able to use them at the 
same time.

Now, it looks to me the AGP GART code mostly calls itself agpgart.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/