linux-kernel - Re: [PATCH -v7 1/3] x86 boot: setup data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <471E729F.3000105@zytor.com>
Date:	Tue, 23 Oct 2007 15:15:59 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	"Huang, Ying" <ying.huang@...el.com>, Andi Kleen <ak@...e.de>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	akpm@...ux-foundation.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -v7 1/3] x86 boot: setup data

Jeremy Fitzhardinge wrote:
>>  1:
>> +	movl boot_params - __PAGE_OFFSET + SETUP_DATA_POINTER,%ebp
> 
> You need to check the boot protocol version before looking at this pointer.
> 

No, he doesn't.  The boot protocol version is communication between the 
boot loader and the kernel (specifically, it is communication FROM the 
kernel TO the bootloader), not between internal bits of the kernel.  Th

Since the pointer is safely inside the setup template, even if the 
bootloader doesn't understand boot protocol version 2.08 it will have 
copied it.

So this is fine.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/