linux-kernel - Re: [PATCH 6/12] KVM: work around SMP requirement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <471E79E2.2090204@garzik.org>
Date:	Tue, 23 Oct 2007 18:46:58 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Adrian Bunk <bunk@...nel.org>
CC:	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org,
	avi@...ranet.com
Subject: Re: [PATCH 6/12] KVM: work around SMP requirement

Adrian Bunk wrote:
> On Tue, Oct 23, 2007 at 06:36:40PM -0400, Jeff Garzik wrote:
>> KVM is currently completely broken for the !CONFIG_SMP case.
>>
>> drivers/kvm/kvm_main.c: In function ‘kvm_flush_remote_tlbs’:
>> drivers/kvm/kvm_main.c:220: error: implicit declaration of function ‘smp_call_function_mask’
>>
>> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
>> ---
>> I hope the KVM maintainer can come up with a better solution...
>>
>> diff --git a/drivers/kvm/Kconfig b/drivers/kvm/Kconfig
>> index 8749fa4..e35fbc6 100644
>> --- a/drivers/kvm/Kconfig
>> +++ b/drivers/kvm/Kconfig
>> @@ -16,7 +16,7 @@ if VIRTUALIZATION
>>  
>>  config KVM
>>  	tristate "Kernel-based Virtual Machine (KVM) support"
>> -	depends on X86 && EXPERIMENTAL
>> +	depends on X86 && EXPERIMENTAL && SMP
>> ...
> 
> Assuming it won't get fixed soon, the pattern would be "(SMP || BROKEN)".
> 
> The effect is the same, but this makes it more obvious that KVM 
> does not depend architecturally on SMP but just broken.
> 
> Of course, the preferred solution is to simply get KVM fixed...

In general I agree, but I specifically avoided CONFIG_BROKEN in case it 
was an intentional choice to require an SMP kernel.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/