linux-kernel - Re: [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440710222236j481d09a7odfa3ce279644f5bd@mail.gmail.com>
Date:	Mon, 22 Oct 2007 22:36:22 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"travis@....com" <travis@....com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Suresh B Siddha" <suresh.b.siddha@...el.com>,
	"Christoph Lameter" <clameter@....com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 1/1] x86: convert-cpuinfo_x86-array-to-a-per_cpu-array fix

On 10/12/07, travis@....com <travis@....com> wrote:
> This fix corrects the problem that early_identify_cpu() sets
> cpu_index to '0' (needed when called by setup_arch) after
> smp_store_cpu_info() had set it to the correct value.
>
> Signed-off-by: Mike Travis <travis@....com>
> ---
>  arch/x86_64/kernel/smpboot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/arch/x86_64/kernel/smpboot.c     2007-10-12 14:28:45.000000000 -0700
> +++ linux/arch/x86_64/kernel/smpboot.c  2007-10-12 14:53:42.753508152 -0700
> @@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
>         struct cpuinfo_x86 *c = &cpu_data(id);
>
>         *c = boot_cpu_data;
> -       c->cpu_index = id;
>         identify_cpu(c);
> +       c->cpu_index = id;
>         print_cpu_info(c);
>  }
>

why not removing assignment in early_identify_cpu?

YH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/