linux-kernel - [RFC PATCH 0/5] Refcount based Cpu Hotplug. V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071024052931.GA22722@in.ibm.com>
Date:	Wed, 24 Oct 2007 10:59:31 +0530
From:	Gautham R Shenoy <ego@...ibm.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, Rusty Russel <rusty@...tcorp.com.au>,
	Srivatsa Vaddagiri <vatsa@...ibm.com>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Ingo Molnar <mingo@...e.hu>, Oleg Nesterov <oleg@...sign.ru>,
	Paul E McKenney <paulmck@...ibm.com>,
	Richard Gooch <rgooch@...f.csiro.au>,
	Tigran Aivazian <tigran@...azian.fs.co.uk>,
	Shoahua Li <shaohua.li@...ux.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Nathan Lynch <ntl@...ox.com>,
	David Miller <davem@...emloft.net>, Paul Jackson <pj@....com>,
	Josh Triplett <josh@...edesktop.org>,
	Christoph Lameter <clameter@....com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Akinobu Mita <akinobu.mita@...il.com>
Subject: [RFC PATCH 0/5] Refcount based Cpu Hotplug. V2

Hello everyone,

This is the version 2 of the refcount based cpu-hotplug "locking" 
implementation. 

It incorporates the review comments from the first posting which
can be found here --> http://lkml.org/lkml/2007/10/16/118.

Changes since v1:
- !CONFIG_HOTPLUG_CPU part is now handled correctly, thanks
  to the patch from Paul Jackson.

- The cpu_hotplug_begin() uses a waitqueue instead of a completion struct
  where a writer can wait while there are active readers in the system.

- Provided a new API's cpu_maps_update_begin(), cpu_maps_update_done()
  for serializing the updates to cpu_present_map and cpu_online_map.
  Thus threads which update the cpu_present_map should now call
  cpu_maps_update_begin instead of lock_cpu_hotplug(), since they play the
  role of writers.

- pseries_processor_add() , pseries_processor_remove() now use
  cpu_maps_update_begin()/cpu_maps_update_done() in place of
  lock_cpu_hotplug()/unlock_cpu_hotplug().

- Replaced the workqueue_mutex with workqueue_lock, which is a spinlock
  and guards the workqueues list.

- Updated Documentation/cpu-hotplug.txt to reflect get_online_cpus(), 
  put_online_cpus() in place of the old lock_cpu_hotplug(), 
  unlock_cpu_hotplug().

I'm Cc'ing the different subsystem maintainers who might be affected
by the changes in the patchstack. Especially if they rely on
lock_cpu_hotplug() to provide them protection for their local data 
structures as well.

The patchstack which is based against 2.6.23-mm1 has behaved well
when it was stress tested with kernbench running while continuously
performing cpu-hotplug operations on i386, x86_64 and ppc64.

Awaiting your feedback.

Thanks and Regards
gautham.
-- 
Gautham R Shenoy
Linux Technology Center
IBM India.
"Freedom comes with a price tag of responsibility, which is still a bargain,
because Freedom is priceless!"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/