linux-kernel - Re: [PATCH] Fixing the warning in cgroup.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071023232938.34102e7a.akpm@linux-foundation.org>
Date:	Tue, 23 Oct 2007 23:29:38 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	menage@...gle.com, Balbir Singh <balbir@...ux.vnet.ibm.com>,
	vatsa@...ux.vnet.ibm.com, Dhaval Giani <dhaval@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fixing the warning in cgroup.c

On Sun, 21 Oct 2007 23:00:20 +0530 Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com> wrote:

> Removing the unused variable root.
> 
> kernel/cgroup.c: In function ‘proc_cgroupstats_show’:
> kernel/cgroup.c:2405: warning: unused variable ‘root’

ERROR: Invalid UTF-8
#3: 
kernel/cgroup.c: In function proc_cgroupstats_show:

ERROR: Invalid UTF-8
#4: 
kernel/cgroup.c:2405: warning: unused variable root

total: 2 errors, 0 warnings, 7 lines checked
Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.



Please use LANG=C so gcc doesn't do this.

> Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
> 
> Index: linux-git/kernel/cgroup.c
> ===================================================================
> --- linux-git.orig/kernel/cgroup.c      2007-10-21 08:49:15.000000000 +0530
> +++ linux-git/kernel/cgroup.c   2007-10-21 22:24:13.000000000 +0530
> @@ -2402,7 +2402,6 @@ struct file_operations proc_cgroup_opera
>  static int proc_cgroupstats_show(struct seq_file *m, void *v)
>  {
>         int i;
> -       struct cgroupfs_root *root;
> 
>         seq_puts(m, "#subsys_name\thierarchy\tnum_cgroups\n");
>         mutex_lock(&cgroup_mutex);

your email client is converting tabs to spaces.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/