linux-kernel - Re: [PATCH] Remove bogus default y for DMAR and NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <471F0F44.4010102@garzik.org>
Date:	Wed, 24 Oct 2007 05:24:20 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Andi Kleen <ak@...e.de>
CC:	linux-kernel@...r.kernel.org, akpm@...l.org,
	shannon.nelson@...el.com, anil.s.keshavamurthy@...el.com
Subject: Re: [PATCH] Remove bogus default y for DMAR and NET_DMA

Andi Kleen wrote:
> Index: linux-2.6.24-rc1-hack/arch/x86_64/Kconfig
> ===================================================================
> --- linux-2.6.24-rc1-hack.orig/arch/x86_64/Kconfig
> +++ linux-2.6.24-rc1-hack/arch/x86_64/Kconfig
> @@ -753,7 +753,6 @@ config PCI_DOMAINS
>  config DMAR
>  	bool "Support for DMA Remapping Devices (EXPERIMENTAL)"
>  	depends on PCI_MSI && ACPI && EXPERIMENTAL
> -	default y
>  	help
>  	  DMA remapping (DMAR) devices support enables independent address
>  	  translations for Direct Memory Access (DMA) from devices.

ACK


> Index: linux-2.6.24-rc1-hack/drivers/dma/Kconfig
> ===================================================================
> --- linux-2.6.24-rc1-hack.orig/drivers/dma/Kconfig
> +++ linux-2.6.24-rc1-hack/drivers/dma/Kconfig
> @@ -43,7 +43,6 @@ comment "DMA Clients"
>  config NET_DMA
>  	bool "Network: TCP receive copy offload"
>  	depends on DMA_ENGINE && NET
> -	default y
>  	help
>  	  This enables the use of DMA engines in the network stack to
>  	  offload receive copy-to-user operations, freeing CPU cycles.

ACK -- but its arguable that given the current code, its worth setting 
this if DMA_ENGINE is also set.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/