linux-kernel - Re: [PATCH -mm 02/11] PCI: add device_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <471F2DAF.7030800@garzik.org>
Date:	Wed, 24 Oct 2007 07:34:07 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	FUJITA Tomonori <tomof@....org>
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, greg@...ah.com,
	James.Bottomley@...elEye.com, fujita.tomonori@....ntt.co.jp
Subject: Re: [PATCH -mm 02/11] PCI: add device_dma_parameters support

FUJITA Tomonori wrote:
> index 463a5a9..54edea2 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -985,8 +985,11 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus)
>  
>  	set_dev_node(&dev->dev, pcibus_to_node(bus));
>  	dev->dev.dma_mask = &dev->dma_mask;
> +	dev->dev.dma_parms = &dev->dma_parms;
>  	dev->dev.coherent_dma_mask = 0xffffffffull;
>  
> +	pci_set_dma_max_seg_size(dev, 65536);

this should check the return value of pci_set_dma_max_seg_size(), and do 
something useful.

ACK everything else

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/