lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Oct 2007 15:39:09 +0400 From: Alexey Dobriyan <adobriyan@...ru> To: Ingo Molnar <mingo@...e.hu> Cc: Pekka Enberg <penberg@...helsinki.fi>, akpm@...l.org, linux-kernel@...r.kernel.org, devel@...nvz.org Subject: Re: [PATCH] Bogus KERN_ALERT on oops On Wed, Oct 24, 2007 at 12:33:18PM +0200, Ingo Molnar wrote: > > * Pekka Enberg <penberg@...helsinki.fi> wrote: > > > > - printk(KERN_ALERT "*pde = %016Lx ", page); > > > + printk("*pde = %016Lx ", page); > > > > Use the new KERN_CONT annotation here? > > indeed - i changed the patch to do that. Might as well change comment around KERN_CONT -- for starters it lied about "early bootup" phase since day one. Proposed text: /* * Annotation for a "continued" line of log printout (only done * after a line that had no enclosing \n). * * Introduced because checkpatch.pl couldn't be arsed to learn C * and distinguish continued printk() from the one that starts * new line. * * Caveat #1: Empty string-literal, so compiler can't check for * KERN_CONT misuse. * Caveat #2: Empty string-literal, so it can't be used in * printk(var); situations. * Caveat #3: takes characters on the screen, so code is harder * to read. * Caveat #4: checkpatch.pl doesn't know C, so it can't check * for KERN_CONT misuse, anyway. */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists