linux-kernel - Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071024124123.GD30533@stusta.de>
Date:	Wed, 24 Oct 2007 14:41:23 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	"Robert P. J. Day" <rpjday@...shcourse.ca>,
	Sam Ravnborg <sam@...nborg.org>,
	Haavard Skinnemoen <hskinnemoen@...el.no>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage

On Wed, Oct 24, 2007 at 02:21:20PM +0200, Jens Axboe wrote:
> On Wed, Oct 24 2007, Robert P. J. Day wrote:
> > On Wed, 24 Oct 2007, Sam Ravnborg wrote:
> > 
> > > On Wed, Oct 24, 2007 at 01:24:53PM +0200, Jens Axboe wrote:
> > > > On Wed, Oct 24 2007, Haavard Skinnemoen wrote:
> > > > > Hi Linus,
> > > > >
> > > > > Sorry about sending you pull requests so rapidly, but Jens broke my
> > > > > dma-mapping.h yesterday. Or you may say the bug was there to begin with
> > > > > and Jens merely exposed it, but that makes it sound like my fault ;-)
> > > > >
> > > > > Anyway, please pull from
> > > > >
> > > > >   ssh://master.kernel.org/pub/scm/linux/kernel/git/hskinnemoen/avr32-2.6.git for-linus
> > > > >
> > > > > to receive the following update.
> > > >
> > > > You should not take the blame :-)
> > > >
> > > > I'm collecting these patches, so I'll pull your fix and make sure it
> > > > gets to Linus today along with the other fixes.
> > >
> > > How about doing a "git grep asm/scatterlist"
> > > and fix all victims to use linux/scatterlist?
> > > Or you maybe did this already.
> > 
> > i was just about to ask -- is this one of those cases where the asm
> > versions of scatterlist.h should have a warning/error that they should
> > not be included directly, and to include linux/scatterlist.h instead?
> 
> No, using asm/scatterlist.h is perfectly fine. The problem is code using
> the sg helpers should include linux/scatterlist.h since that is where
> those are defined.
> 
> If you just need the scatterlist structure definition, then
> asm/scatterlist.h is the correct include.

But there's also the general question whether it's good practice for 
not architecture specific code to include asm/ headers.

For APIs available on all architectures linux/ header are the right 
thing to use, and what is in the asm/ header and what in the linux/ 
header becomes an implementation detail that can be changed.

> Jens Axboe

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/