lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20071023192948.1fe5dd8d.akpm@linux-foundation.org> Date: Tue, 23 Oct 2007 19:29:48 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Gilles Gigan <gilles.gigan@...il.com> Cc: wim@...ana.be, linux-kernel@...r.kernel.org Subject: Re: [PATCH] watchdog: add Nano 7240 driver On Wed, 24 Oct 2007 12:11:59 +1000 Gilles Gigan <gilles.gigan@...il.com> wrote: > + case WDIOC_SETOPTIONS:{ > + int retval = -EINVAL; > + > + if (arg & WDIOS_DISABLECARD) { > + wdt_disable(); > + retval = 0; > + } > + > + if (arg & WDIOS_ENABLECARD) { > + wdt_enable(); > + retval = 0; > + } > + > + return retval; hrm. So if userspace does ioctl(..., WDIOS_DISABLECARD|WDIOS_ENABLECARD, that happens to be equivalent to WDIOS_ENABLECARD? Do all watchdog drivers do it exactly the same way, or are we offering inconsistent interfaces between different drivers? An exceedingly minor point, but fun nonetheless. (And hey, I had to say _something_) (apart from directing your attention to scripts/checkpatch.pl) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists