linux-kernel - Re: [2.6 patch] kernel/cgroup.c: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071024103411.dfd3ae04.pj@sgi.com>
Date:	Wed, 24 Oct 2007 10:34:11 -0700
From:	Paul Jackson <pj@....com>
To:	"Paul Menage" <menage@...gle.com>
Cc:	bunk@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] kernel/cgroup.c: remove dead code

Paul M wrote:
> I think I'd rather not make this change - if we later changed the size
> of release_agent_path[] this could silently fail. Can we get around
> the coverity checker somehow?

Perhaps we can simplify this check then, to:

  BUG_ON(sizeof(cgrp->root->release_agent_path) < PATH_MAX));

Less runtime code.

This patch of Adrian highlighted a couple more opportunities
for code tweaking ... see my RFC patches, coming next from me.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/